fix: prevent "The libp2p node is not started yet" when stopping #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Nice! good catch! |
jacobheun
pushed a commit
to jacobheun/js-libp2p
that referenced
this pull request
Jul 29, 2019
maschad
added a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
…2p#134) * fix: added peer connection state listener to emit closed events * fix: updated listening event name for disconnect/closed events (libp2p#138) * fix: removed listener once connection is closed (libp2p#138) * fix: removed listener once connection is closed (libp2p#138)
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [1.1.8](libp2p/js-libp2p-webrtc@v1.1.7...v1.1.8) (2023-04-25) ### Bug Fixes * added peer connection state listener to emit closed events ([libp2p#134](libp2p/js-libp2p-webrtc#134)) ([16e8503](libp2p/js-libp2p-webrtc@16e8503)), closes [libp2p#138](libp2p/js-libp2p-webrtc#138) [libp2p#138](libp2p/js-libp2p-webrtc#138) [libp2p#138](libp2p/js-libp2p-webrtc#138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When issuing a
node.stop(), some asynchronous actions may still be happening, which sometimes originates random "The libp2p node is not started yet" errors.This prevents that by assuming the node is only stopped after the stopping process is complete.