Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I rewrite this thing in TypeScript? #858

Closed
midzdotdev opened this issue Jan 7, 2021 · 3 comments
Closed

Can I rewrite this thing in TypeScript? #858

midzdotdev opened this issue Jan 7, 2021 · 3 comments

Comments

@midzdotdev
Copy link

I'd like to learn more about libp2p because it's awesome.

I'd also like to improve my TS skills + type safety is a desirable thing to have for a framework as sophisticated as this one.

Thoughts? :)

@vasco-santos
Copy link
Member

Hello @james2mid

We currently generate typescript declaration files on release, using types defined in jsdocs per #802 , so that libp2p users within typescript projects can use it easily. However, we are not looking for an entire rewrite of the codebase to typescript for 2 main reasons:

  • time needed to so such a major revamp to all libp2p modules, which would mean more important features would not be done
  • from a contribution perspective, it will be easier to contribute to libp2p as a JS project because all TS developers know JS, but not all JS developers know TS.

If you are still interested in helping out with other types of tasks let us know. There are a lot of issues labeled with ready and easy that you can have a look if you like

@midzdotdev
Copy link
Author

I appreciate your reply. I'm keen to help out so I'll check out the available issues :)

Aside from the libp2p documentation, are there any learning resources you can recommend surrounding P2P and other related topics?

@vasco-santos
Copy link
Member

I appreciate your reply. I'm keen to help out so I'll check out the available issues :)

That would be super helpful. Let me know what would you like to get and we can discuss it further if you need. By the way, there is #659 and #830 in the context of adding types to jsdocs to create type declarations on build that you can have a look if you are interested in typescript thematic.

Aside from the libp2p documentation, are there any learning resources you can recommend surrounding P2P and other related topics?

Have a look at this issue: libp2p/libp2p#56 It has a lot of nice resources for the P2P space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants