Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: event emitter and interfaces types for discovery and routing #934

Merged
merged 7 commits into from
Apr 30, 2021
Merged

fix: event emitter and interfaces types for discovery and routing #934

merged 7 commits into from
Apr 30, 2021

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Apr 29, 2021 •
edited
Loading

Needs to have dist folder removed (testing with lodestar for now)

Tested with ChainSafe/lodestar#2442 for last fixes. There is a fix/event-emitter-types-with-local-types-dist branch with the build commited to test in lodestar

Needs:

@vasco-santos vasco-santos force-pushed the fix/event-emitter-types-with-local-types branch from 74dc25d to 6cee58e Compare April 29, 2021 12:59
@vasco-santos vasco-santos mentioned this pull request Apr 29, 2021
Closed
4 tasks
@vasco-santos vasco-santos force-pushed the fix/event-emitter-types-with-local-types branch 2 times, most recently from d78962b to d92ff16 Compare April 29, 2021 14:31
@vasco-santos vasco-santos changed the title fix: event emitter types with local types fix: interfaces types for discovery and routing Apr 29, 2021
@vasco-santos vasco-santos changed the title fix: interfaces types for discovery and routing fix: event emitter, interfaces types for discovery and routing Apr 29, 2021
@vasco-santos vasco-santos changed the title fix: event emitter, interfaces types for discovery and routing fix: event emitter and interfaces types for discovery and routing Apr 29, 2021
@vasco-santos vasco-santos force-pushed the fix/event-emitter-types-with-local-types branch 2 times, most recently from 0603995 to 46d58ce Compare April 29, 2021 17:16
@achingbrain
Copy link
Member

src/types.d.ts is a new, empty file? Was it added by mistake?

@vasco-santos
Copy link
Member Author

src/types.d.ts is a new, empty file? Was it added by mistake?

Yes, removing it now

achingbrain
achingbrain approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending GH dep version removal

@vasco-santos vasco-santos force-pushed the fix/event-emitter-types-with-local-types branch from 6b50b26 to 6a40a93 Compare April 30, 2021 10:23
@vasco-santos vasco-santos marked this pull request as ready for review April 30, 2021 11:19
@vasco-santos
Copy link
Member Author

shipped moving-averages on my npm namespace until we have a final release to unblock this

@vasco-santos vasco-santos merged commit 302bb90 into master Apr 30, 2021
@vasco-santos vasco-santos deleted the fix/event-emitter-types-with-local-types branch April 30, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @achingbrain