Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request-response: closes substream before keep alive is reached or response is sent #1903

Closed
dvc94ch opened this issue Dec 23, 2020 · 2 comments
Closed

request-response: closes substream before keep alive is reached or response is sent #1903

dvc94ch opened this issue Dec 23, 2020 · 2 comments

Comments

@dvc94ch
Copy link
Contributor

dvc94ch commented Dec 23, 2020 •
edited
Loading

This results in RequestResponseEvent::OutboundFailure with reason ConnectionClosed.
@dvc94ch
Copy link
Contributor Author

dvc94ch commented Dec 25, 2020

Seems like the problem is a different one. The multiplexer buffers the response and receives a close. When polling for incoming substreams an error happens because the remote closed the connection. This causes the muxer to drop the buffered frames and the response to be lost. This happens both in mplex and yamux, the reason being that the StreamMuxer::poll_event doesn't allow returning None, which is what it probably should do.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Dec 25, 2020 •
edited
Loading

So the problem is that I dropped the swarm too early in the tests 🤦 which caused the above error. Related to #1682

@dvc94ch dvc94ch closed this as completed Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvc94ch