Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossipsub: documented TODO #4557

Closed
drHuangMHT opened this issue Sep 26, 2023 · 4 comments
Closed

gossipsub: documented TODO #4557

drHuangMHT opened this issue Sep 26, 2023 · 4 comments

Comments

@drHuangMHT
Copy link
Contributor

unused_doc_comments now generates warning.

/// TODO, see https://github.com/libp2p/specs/pull/217

@thomaseizinger
Copy link
Contributor

What kind of warning? Is it easy to fix?

It is a shame that denying warnings doesn't work for rustdoc: #3282

@drHuangMHT
Copy link
Contributor Author

The warning is as follows:

warning: unused doc comment
   --> C:\Users\DrHuang\Documents\GithubProjects\rust-libp2p\protocols\gossipsub\src\types.rs:333:33
    |
333 | ...                   /// TODO, see https://github.com/libp2p/specs/pull/217
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
334 | ...                   signed_peer_record: None,
    |                       ------------------------ rustdoc does not generate documentation for expression fields
    |
    = help: use `//` for a plain comment
    = note: `#[warn(unused_doc_comments)]` on by default

The easiest fix will be changing triple slashes to double slashes, but #217 has been resolved.

@thomaseizinger
Copy link
Contributor

The relevant feature here is called "peer exchange" and is tracked here: #2398

Could you send a PR though to fix the warning by not using a triple-slash?

@drHuangMHT
Copy link
Contributor Author

Fixed in #4811.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants