Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Share feature #142

Closed
TheMeanCanEHdian opened this issue Jul 25, 2018 · 10 comments
Closed

Feature Request: Share feature #142

TheMeanCanEHdian opened this issue Jul 25, 2018 · 10 comments

Comments

@TheMeanCanEHdian
Copy link

It would be nice to temporarily store images of the speed test results (or similar) and allow users to share the path to the image rather than have to take a screenshot.

@dunklesToast
Copy link
Member

Hmmm. At first I would create page where you can view the telemetry results.
Something like: https://youspeedtest.host/result/
If this feature works, we could implement image generation.

@adolfintel
Copy link
Member

I've been planning on doing this for a while but I've always been busy with other stuff.
We could return an ID with the telemetry and then add a page like result.php?id=##

@adolfintel
Copy link
Member

Image generation could also be an option but I don't want to store thousands of useless images on the server so it has to be done when the request comes in

@adolfintel
Copy link
Member

I'm working on this feature right now using PHP and FreeType2 for image generation.
@dunklesToast I've also reorganized the telemetry and results files to avoid having a bunch of files around, you might have to reorganize the node branch too when I'm done before you can merge version 4.6

@adolfintel
Copy link
Member

Implemented in 4.6

@adolfintel
Copy link
Member

image

@monacheprojects
Copy link

Hello, I want to know if there is a way to change the share URL to http://hostname/speed/results/?ip="ip address here" with a history at least 5 past speed results?

@adolfintel
Copy link
Member

@monacheprojects it can be done but I don't have time to do it right now, maybe in a future version

@monacheprojects
Copy link

@monacheprojects it can be done but I don't have time to do it right now, maybe in a future version

Have you looked into this yet?

@adolfintel
Copy link
Member

@monacheprojects Unfortunately no, I have added other features and improvements first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants