Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for ls-NonFileTypes #318

Closed
sayedihashimi opened this issue Nov 19, 2015 · 1 comment
Closed

Remove the need for ls-NonFileTypes #318

sayedihashimi opened this issue Nov 19, 2015 · 1 comment

Comments

@sayedihashimi
Copy link
Member

Currently we look through the project file to figure out what files need to be merged with the .vstemplate file. Many project files have items which do not point to files. The current design for this is that we have ls-NonFileTypes to figure out what items to ignore during the .csproj->.vstemplate merge. This has caused issues with new project types.

Instead of this, we should just check for the existence of the file on disk. If the file is not there issue a message and then just ignore it. Then we can just get rid of ls-NonFileTypes.

@codewithtyler
Copy link
Member

@sayedihashimi since this is something that will need to be fixed in TemplateBuilder I've created an issue there so we have a record of it. In the mean time I'm going to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants