Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriber Groups button are inaccessible/unclickable or glitched in every of layouts with PocketTube #13

Open
Aleksandra0056 opened this issue May 31, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@Aleksandra0056
Copy link

Aleksandra0056 commented May 31, 2023

Problem description:

  • The Subscriber Groups sidebar section (with PocketTube extension installed) is unclickable, which means, that it is inaccessible.
  • Also the buttons in PocketTube are greyed out.
  • The “Deck” button is though clickable, but greyed out too.
  • UPDATE 19:02 (7:02 PM): The blue tick mark/check mark in the video description from PocketTube is misaligned in some (maybe all (I've not tested every layout)) layouts.

Expected results:

  • The Subscriber Groups in the sidebar should be accessible.
  • The buttons in PocketTube should NOT be greyed out!
  • And for “Deck” button, then it shouldn't have an icon in 2013 layout, and it should have smaller icon in 2014, '15, '16, '17 layouts, and the tooltip/title of that button should be aligned correctly in every of layouts.

Other details:

  • Browser version: Firefox v113.0.2
  • YouTube site zoom percentage: 100%
  • OS version: Windows 11 22621.1778
  • OS architecture: 64-bit
  • Browser architecture: 64-bit
  • CPU: AMD A10-7860K
  • RAM: 16,0GB DDR3
  • Motherboard: MSI A88XM-E35 V2
  • Graphics: 1024MB ATI AMD Radeon R7

Screenshots:

  • SCREENSHOT NOTE: “Skupiny Odberov” means “Subscriber Groups”.
  • WARNING: Inaccurate accessibility due to black arrows icons, black text & dark grey background in this screenshot!

image

@lightbeam24
Copy link
Owner

I haven't used PocketTube, but based on your screenshot, it looks like PocketTube is creating its own sidebar elements that use separate styling from the native YouTube sidebar items. So basically this only happens because CustomTube wasn't tested with PocketTube. (The only other extensions/scripts CustomTube was tested with are uBlock Origin and Return YouTube Dislike.)

I'll look into it though. In the meantime, could you tell me if it happens on other layouts? In this situation, it would be most helpful to test on the 2013, 2017, and 2019 layouts. If it happens on all three of those layouts, test it with "Layout Select" set to "Disabled".

@Aleksandra0056
Copy link
Author

Aleksandra0056 commented May 31, 2023

In the 2013, the PocketTube is not only inaccessible, but also large, and the “Deck” button has an icon, and also under some icons there are grey YouTube buttons underneath them (Wait for me to test the 2017, and 2019 please…)
image

@Aleksandra0056
Copy link
Author

Aleksandra0056 commented May 31, 2023

2014 PocketTube is clickable, but the buttons are large, and “Deck” button is misaligned (Not unclickable, sorry), and Deck have bad outline (Sorry, but you must wait, because I have some things to do with Firefox's CSS, so be patient…):
image

@Aleksandra0056
Copy link
Author

Aleksandra0056 commented May 31, 2023

Well, 2015 is same as 2014. (Sorry for delay, but I changed some CSS files in my Firefox (Which are unrelated to this issue))

@Aleksandra0056
Copy link
Author

Aleksandra0056 commented May 31, 2023

2016 is ditto as 2015, and 2014.

2017 is also the same.

@lightbeam24
Copy link
Owner

lightbeam24 commented May 31, 2023

Yeah 2014-2017 should all be the same, there isn't much of a need to test them all. They share most of their code, excluding the watch page.

@Aleksandra0056
Copy link
Author

Aleksandra0056 commented May 31, 2023

And for 2019, then there is wrong outline shade for Deck button, and the Sub. Collections are using wrong buttons shape, they should be square instead of rounded. (And Sub. Collections are clickable/accessible!)

image

@lightbeam24
Copy link
Owner

Okay, so that adds weight to my theory that PocketTube uses it's own CSS to style its sidebar items. I'll look into fixing it.

@Aleksandra0056 Aleksandra0056 changed the title Subscriber Groups button are inaccessible/unclickable from sidebar in 2012 layout with PocketTube Subscriber Groups button are inaccessible/unclickable or glitched in every of layouts with PocketTube May 31, 2023
@Aleksandra0056
Copy link
Author

Aleksandra0056 commented May 31, 2023

Please, I need your answer, is this blue tick mark feature of YouTube, or feature of PocketTube?
image

  • If it is feature of YouTube, then it needs to be fixed (because it is off-set), if it is feature of PocketTube, then I don't know.
  • It is early 2013 layout.

@lightbeam24
Copy link
Owner

I don't have that blue checkmark, so it must be PocketTube.

@Aleksandra0056
Copy link
Author

Aleksandra0056 commented May 31, 2023

Fine, I will write it to description, and title.

UPDATE: It is right in description. Not title for now, because I don't have any idea how the title should be written with more things.

@lightbeam24 lightbeam24 added the enhancement New feature or request label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants