Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Filter button in the wrong place while searching #29

Closed
gameshowrecaps opened this issue Jun 22, 2023 · 6 comments
Closed

Search Filter button in the wrong place while searching #29

gameshowrecaps opened this issue Jun 22, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@gameshowrecaps
Copy link

Search filter is supposed to be to the left. (It also now opens a screen with the search filters instead of just displaying them)
Screenshot 2023-06-21 230640

@lightbeam24
Copy link
Owner

This is a new change that YouTube is A/B testing (it's called "Search Header" I believe). It's not caused by the extension.

I plan to try to make CustomTube work with Search Header in the future, though I'm not sure if it will be possible to fully fix it (the filters window in particular might be difficult to fix).

@gameshowrecaps
Copy link
Author

I'm late but I can confirm they are A/B testing this. My alt has filters in the normal place and my main has it to the right. I haven't heard anybody talking about this anywhere.

@lightbeam24
Copy link
Owner

lightbeam24 commented Jun 30, 2023

They're also A/B testing another version of Search Header with a filter bar. I would assume (hope) this is the version that they plan on going with, because otherwise it is a completely pointless change. Either way, Search Header in general is the reason why CustomTube doesn't affect search filters yet (why bother styling the old search filters when I know they're gonna replace it).

searchheadr

Edit: Oh and the reason why I haven't edited Search Header yet is because this was in a private window and I don't actually have it yet.

@gameshowrecaps
Copy link
Author

And it has happened finally for me and my alt. They went for the version posted above.

@lightbeam24
Copy link
Owner

Yes, it seems they've rolled it out to most people if not everyone by now. I'm currently trying to think of how exactly to go about fixing this. I personally don't think the addition of the chip bar is a terrible change, and am considering keeping it in, or at least making it optional. The big problem though will be the filters menu itself, which will probably remain a window for a while until I find a way to fix that.

No matter what I decide to do, the filters button will be moved back to the left.

@lightbeam24 lightbeam24 added the enhancement New feature or request label Oct 9, 2023
@lightbeam24
Copy link
Owner

This was fixed a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants