Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be More Conservative on Sending Shutdown #1337

Open
TheBlueMatt opened this issue Feb 28, 2022 · 3 comments
Open

Be More Conservative on Sending Shutdown #1337

TheBlueMatt opened this issue Feb 28, 2022 · 3 comments
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@TheBlueMatt
Copy link
Collaborator

cc lightning/bolts#964 but we need to update our shutdown sending/handling - we should accept a shutdown even if there's pending updates, and we also need to consider update_fail/update_fail_malformed and update_fee as "pending updates".

@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Feb 28, 2022
@dunxen
Copy link
Contributor

dunxen commented May 2, 2022

If this is still relevant I'd be happy to run with it, unless there is some other deeper context I'd need to be aware of / cannot easily discover in LDK's handling.

@TheBlueMatt
Copy link
Collaborator Author

I'd let this one sit for a bit. There continues to be some debate in the BOLTs as to the correct direction here, with multiple alternative PRs going different directions.

@TheBlueMatt TheBlueMatt added the Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment label May 6, 2024
@TheBlueMatt TheBlueMatt removed this from the 0.1 milestone May 6, 2024
@TheBlueMatt
Copy link
Collaborator Author

May have been at least partially addressed by #2529?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
Development

No branches or pull requests

2 participants