Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functional tests fail when block listeners are registered "out of order" #492

Closed
valentinewallace opened this issue Feb 11, 2020 · 1 comment

Comments

@valentinewallace
Copy link
Contributor

When this line and line 893 are swapped, 23 of the functional tests fail. Seems overly fragile and was a bit confusing to debug.

Here are the failures:

failures:
    ln::functional_tests::channel_monitor_network_test
    ln::functional_tests::claim_htlc_outputs_shared_tx
    ln::functional_tests::claim_htlc_outputs_single_tx
    ln::functional_tests::revoked_output_claim
    ln::functional_tests::test_bump_penalty_txn_on_remote_commitment
    ln::functional_tests::test_bump_penalty_txn_on_revoked_commitment
    ln::functional_tests::test_bump_penalty_txn_on_revoked_htlcs
    ln::functional_tests::test_bump_txn_sanitize_tracking_maps
    ln::functional_tests::test_claim_on_remote_revoked_sizeable_push_msat
    ln::functional_tests::test_duplicate_htlc_different_direction_onchain
    ln::functional_tests::test_duplicate_payment_hash_one_failure_one_success
    ln::functional_tests::test_dynamic_spendable_outputs_local_htlc_success_tx
    ln::functional_tests::test_dynamic_spendable_outputs_local_htlc_timeout_tx
    ln::functional_tests::test_htlc_on_chain_success
    ln::functional_tests::test_htlc_on_chain_timeout
    ln::functional_tests::test_justice_tx
    ln::functional_tests::test_onchain_to_onchain_claim
    ln::functional_tests::test_set_outpoints_partial_claiming
    ln::functional_tests::test_static_spendable_outputs_justice_tx_revoked_commitment_tx
    ln::functional_tests::test_static_spendable_outputs_justice_tx_revoked_htlc_success_tx
    ln::functional_tests::test_static_spendable_outputs_justice_tx_revoked_htlc_timeout_tx
    ln::functional_tests::test_static_spendable_outputs_preimage_tx
    ln::functional_tests::test_sweep_outbound_htlc_failure_update
@tnull
Copy link
Contributor

tnull commented Jul 8, 2024

Closing this as hard to tell what the referenced lines were by now.

@tnull tnull closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants