Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web ui after all channels with peer are closed #46

Open
joostjager opened this issue Feb 6, 2023 · 1 comment
Open

Update web ui after all channels with peer are closed #46

joostjager opened this issue Feb 6, 2023 · 1 comment

Comments

@joostjager
Copy link
Contributor

Currently in circuit breaker, peers are only removed from the list after a restart. This issue is about making circuit breaker remove peers on the fly when all channels are closed.

One thing to keep in mind is that there may be custom limits for the peer that is removed. When in the future a channel is re-opened to that peer, it is the question which limit should apply. The old custom one, or should it switch back to default?

Originally reported in #40

@M1ch43lV
Copy link

M1ch43lV commented Feb 6, 2023

I suggest to keep the information to the old peer after closing the channel. It might be that you or the old peer reinitiate soon a new channel, maybe because it had been force-closed or accidentally been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants