-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exceptions from RUNTIME_PM_ON_*="" are not possible atm #614
Comments
Hi, indeed a very special use case. Btw it's not BIOS defaults but kernel driver defaults.
In the meantime, you can trick the logic with an invalid value:
|
Hi, thanks for your workaround. It works as expected, so you can leave the code unchanged. Perhaps this workaround should be documented? |
@Mintulix What lasts long becomes implemented after all :-). If you still follow this: please test with the main branch. Important: you need to change your config to
because "nil" is now considered invalid and the whole feature skipped. |
Hey, within one year, what more could one want? ;-) |
Great. Thanks for testing. @linrunner : add use case to the doc https://linrunner.de/tlp/settings/runtimepm.html |
TLP 1.5.0
What I want:
Using the Bios defaults for all PCI devices in AC and BAT mode with one exception (Nvidia dGPU should always be in PM-mode, because the Intel iGPU alone is used).
How to accomplish that:
Method 1a (works):
Method 1b (works):
Method 2 (preferred, much more elegant, but it doesn't work because RUNTIME_PM_ENABLE is ignored):
The "faulty" code part is in /usr/share/tlp/func.d/05-tlp-func-pm:
I'm sure it's there for a reason, but for me disabling the "return 0" does the trick.
What do you think? Should method 2 be allowed, or rather why must there be a return if RUNTIME_PM_ON_* is unconfigured?
The text was updated successfully, but these errors were encountered: