Skip to content

Commit

Permalink
Squashfs: add extra sanity checks at mount time
Browse files Browse the repository at this point in the history
Add some extra sanity checks of the inode and directory structures.

Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk>
  • Loading branch information
Phillip Lougher committed May 25, 2011
1 parent 1cac63c commit 1094a4a
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions fs/squashfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent)
handle_fragments:
fragments = le32_to_cpu(sblk->fragments);
if (fragments == 0)
goto allocate_root;
goto check_directory_table;

msblk->fragment_cache = squashfs_cache_init("fragment",
SQUASHFS_CACHED_FRAGMENTS, msblk->block_size);
Expand All @@ -286,8 +286,22 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent)
msblk->fragment_index = NULL;
goto failed_mount;
}
next_table = msblk->fragment_index[0];

allocate_root:
check_directory_table:
/* Sanity check directory_table */
if (msblk->directory_table >= next_table) {
err = -EINVAL;
goto failed_mount;
}

/* Sanity check inode_table */
if (msblk->inode_table >= msblk->directory_table) {
err = -EINVAL;
goto failed_mount;
}

/* allocate root */
root = new_inode(sb);
if (!root) {
err = -ENOMEM;
Expand Down

0 comments on commit 1094a4a

Please sign in to comment.