Backport fix of D106431: Fix cppcoreguidelines-init-variables by removing the enum FixIt

[whisperity]

Bugzilla Link	51248
Resolution	FIXED
Resolved on	Oct 11, 2021 20:29
Version	unspecified
OS	All
Blocks	#51489
CC	@tstellar
Fixed by commit(s)	4a097ef 8dcdfc0

Extended Description

A fix for "cppcoreguidelines-init-variables" that removes a badly generated FixIt suggestion is seemingly approaching acceptance, and the patch resulting from it should be merged into 13.0.

[whisperity]

assigned to @tstellar

[whisperity]

@​tstellar Please backport commit 4a097ef (the fix that landed on main for D106431) to the release/13.x branch, it fixes a bug in which Clang-Tidy generates a broken fix and if people apply the fix automatically their code won't compile anymore.

[tstellar]

This does not cherry-pick cleanly, can you cherry-pick and push to a personal github repo or attach a patch?

[whisperity]

The rebased and fixed-up patch for the release/13.x branch
@​tstellar Yeah, the usual stuff with conflicts in the release notes... I've fixed the patch, please find the generated output.

I've applied this over the following commit locally to produce:

commit 0661286 (HEAD -> release/13.x, upstream/release/13.x)
Author: Eli Friedman
Date: Sat Jul 31 13:41:15 2021 -0700

Fix a couple regression tests I missed updating in 2a284782

[whisperity]

Gentle bump. AFAICT this still hasn't made it to the release branch.

[tstellar]

Merged: 8dcdfc0

[whisperity]

Thanks!

[tstellar]

mentioned in issue #51489