Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport lldb AArch64 memory tagging commands changes to 13.x branch #50624

Closed
DavidSpickett opened this issue Jul 30, 2021 · 4 comments
Closed
Labels
bugzilla Issues migrated from bugzilla lldb

Comments

@DavidSpickett
Copy link
Collaborator

Bugzilla Link 51280
Resolution FIXED
Resolved on Oct 11, 2021 20:29
Version unspecified
OS Linux
Blocks #51489
CC @JDevlieghere,@tstellar
Fixed by commit(s) 98b5659 555cd03 d510b5f 6eded00 6a7a2ee 0b8dc91 c47d79b bc0cc10 dc00e19 45d9885

Extended Description

Currently 13.x has a "memory tag read" command and half the supporting code for "memory tag write". Backporting the following patches would complete the tag write command, and the basic memory tagging feature set for lldb 13.

6a7a2ee https://reviews.llvm.org/D105182 - Memory tag write command
6eded00 https://reviews.llvm.org/D105183 - Memory tag write "--end-addr" option
d510b5f https://reviews.llvm.org/D105178 - Annotate synchronous tag faults
555cd03 https://reviews.llvm.org/D104914 - Correct memtags packets type field format
98b5659 https://reviews.llvm.org/D106880 - Mark mismatched tags in "memory tag read" output

Ok to cherry pick these to the branch?

Also I'd like to add these features to the lldb release notes. Can I do that directly or should I put up a phabricator review for it first?

@tstellar
Copy link
Collaborator

tstellar commented Aug 2, 2021

Go ahead and cherry-pick these and update the release notes too.

@DavidSpickett
Copy link
Collaborator Author

Cherry picks done and release notes updated, resolving.

@tstellar
Copy link
Collaborator

tstellar commented Aug 5, 2021

Merged: 45d9885

@tstellar
Copy link
Collaborator

mentioned in issue #51489

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla lldb
Projects
None yet
Development

No branches or pull requests

2 participants