Backport fix to internalization in the Attributor.

[jhuber6]

Bugzilla Link	51284
Resolution	FIXED
Resolved on	Oct 11, 2021 20:29
Version	trunk
OS	Linux
Blocks	#51489
CC	@tstellar
Fixed by commit(s)	adbaa39 97851a0 6d04cd4 fd5ec45

Extended Description

The previous implementation of function internalization had an issue where the internal copies of functions were called by external versions. This didn't cleanly separate the internal and external code paths which resulted in IPO optimizations incorrectly mixing the two. This resulted in remarks being duplicated for any internalized function if they were enabled among other problems.

This was reviewd in https://reviews.llvm.org/D106931 and committed as adbaa39. A follow-up commit is necessary to fix a test that was failing on one of the built-bots: 97851a0.

[tstellar]

These don't cherry-pick cleanly, could someone create a git branch with these cherry-picked?

[tstellar]

These don't cherry-pick cleanly, could someone create a git branch with
these cherry-picked?

Nevermind, there was a stray comma in the fixed by commits field that cause the cherry-pick to fail.

[tstellar]

Merged: fd5ec45

[tstellar]

mentioned in issue #51489