Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport rG4cacb5cad052 to 13.0.1 #51627

Closed
vchuravy opened this issue Oct 24, 2021 · 5 comments
Closed

backport rG4cacb5cad052 to 13.0.1 #51627

vchuravy opened this issue Oct 24, 2021 · 5 comments
Assignees
@vtjnash
Labels
bugzilla Issues migrated from bugzilla

Comments

@vchuravy
Copy link
Contributor

Bugzilla Link 52285
Resolution FIXED
Resolved on Nov 09, 2021 21:06
Version trunk
OS Linux
Blocks #51489
CC @tstellar
Fixed by commit(s) 4cacb5c 8be24d1

Extended Description

https://reviews.llvm.org/D94813
rG4cacb5cad052b14d37703157f3b7ffc6a6610acc

Currently carried by JuliaLang
@vchuravy
Copy link
Contributor Author

assigned to @vtjnash

@tstellar
Copy link
Collaborator

tstellar commented Nov 8, 2021

Hi ,

What is your opinion on backporting this?

https://reviews.llvm.org/rG4cacb5cad052b14d37703157f3b7ffc6a6610acc

@tstellar
Copy link
Collaborator

tstellar commented Nov 8, 2021

Hi ,

What is your opinion on backporting this?

https://reviews.llvm.org/rG4cacb5cad052b14d37703157f3b7ffc6a6610acc

^ Question for Jameson.

@vtjnash
Copy link
Member

vtjnash commented Nov 8, 2021

Seems safe to me, as it disables an optimization if it doesn't match the expected libc function.

@tstellar
Copy link
Collaborator

Merged: 8be24d1

@tstellar tstellar mentioned this issue Oct 12, 2021
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtjnash vtjnash

Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstellar @vchuravy @vtjnash