Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we call coap_mem_release() on pMsg if PayloadMaxSize is exceeded? #39

Closed
ChrisDinhNZ opened this issue Sep 23, 2019 · 1 comment
Closed

Should we call coap_mem_release() on pMsg if PayloadMaxSize is exceeded? #39

ChrisDinhNZ opened this issue Sep 23, 2019 · 1 comment
Labels
help wanted

Comments

@ChrisDinhNZ
Copy link

Hi there,
When we call CoAP_CreateMessage(), we allocate some buffer for the message. After successfully allocating the buffer we check PayloadMaxSize and return null if exceeded. Should we free the buffer prior to returning or are we relying on the caller to clean up the buffer?

lobaro-coap/src/coap_message.c

Line 165 in 7f5fed4

return NULL;

@niondir
Copy link
Member

niondir commented Sep 24, 2019

I guess a free is missing there, the caller has no reference to the allocated memory as far as I see.

PR is welcome.

@ChrisDinhNZ ChrisDinhNZ mentioned this issue Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't attempt to create message if PayloadMaxSize is exceeded
2 participants
@niondir @ChrisDinhNZ