Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality will always be reset to 10 (fix included) #180

Closed
cloutsocks opened this issue Nov 14, 2019 · 0 comments · Fixed by #191
Closed

Quality will always be reset to 10 (fix included) #180

cloutsocks opened this issue Nov 14, 2019 · 0 comments · Fixed by #191

Comments

@cloutsocks
Copy link

color-thief/src/core.js

Line 34 in 1c70277

if (typeof quality === 'undefined' || Number.isInteger(quality)) {

I believe you meant to check !Number.isInteger(quality), not the inverse. Also, I feel hard-coding the upper limit of 20 shouldn't be a thing, and that it should be a default option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix quality option validation, update npm script syntax, package-lock aaron-hanson/color-thief
1 participant
@cloutsocks