Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to distinguish between active commit log file and all other commit log files in CleanupManager #1078

Closed
richardartoul opened this issue Oct 12, 2018 · 4 comments
Assignees
Labels
area:db All issues pertaining to dbnode C: Commit Log P: Medium

Comments

@richardartoul
Copy link
Contributor

richardartoul commented Oct 12, 2018

Right now, the cleanup manager is unable to distinguish between the active commit log file and other commit log files. This is ok for now because if ever are unable to read the info header of a commit log file, we just ignore it. We'd like to be able to automatically clean up corrupt commit log files in the cleanup manager, but this introduces the issue that a brand new commit log file with an incomplete header is indistinguishable from a corrupt commit log file. As a result of this, we need to expose information about the current commit log file to the cleanup manager in order to facilitate automatic deletion of corrupt files.

@richardartoul
Copy link
Contributor Author

I'll tackle this in a separate P.R once #1066 lands

@richardartoul
Copy link
Contributor Author

Also make sure to re-enable the test: TestCleanupManagerDeletesCorruptCommitLogFiles once this is achieved

@richardartoul richardartoul added P: Medium C: Commit Log area:db All issues pertaining to dbnode labels Oct 16, 2018
@richardartoul
Copy link
Contributor Author

Will be resolved by #1090

@richardartoul
Copy link
Contributor Author

Closed by #1090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:db All issues pertaining to dbnode C: Commit Log P: Medium
Projects
None yet
Development

No branches or pull requests

3 participants