Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS stopped compiling as of yesterday's update #197

Open
novinaw opened this issue Feb 19, 2016 · 8 comments
Open

SCSS stopped compiling as of yesterday's update #197

novinaw opened this issue Feb 19, 2016 · 8 comments

Comments

@novinaw
Copy link

novinaw commented Feb 19, 2016

Hi there,

The compiler has stopped working as of yesterday for compiling scss files. Are there plans to fix this soon?

@madskristensen
Copy link
Owner

Please describe the issue you are seeing in more details.

@novinaw
Copy link
Author

novinaw commented Feb 19, 2016

OK. I don't know what details can be added to "nothing happens"

It was working fine until 5pmEST yesterday, I went home at around 8pm, and it doesn't work.

The SCSS file no longer compiles into .css (though the word "generated" is still there). There are no errors. Neither save on compile, nor the "web compiler > regenerate" works. This is with Visual Studio 2015.

I have tried to uninstalled the plugin and reinstalled, but it's the same problem.

If there's some way you test certain elements, you can ask me to do it, but I don't know how to be more descriptive.

@sk5
Copy link

sk5 commented Feb 23, 2016

Hey @madskristensen, last night my auto compiling broken again. I had commented on a now closed issue a few weeks back about the files not working when you name them without underscores or the file name ending (.scss). Now when I save any of my partials or run in the Task Runner Explorer I just get the "Process terminated with code 0". I went in and tried renaming all of my partials back to having underscores in front and file endings and for a brief moment the Task Runner at least would show the files were compiling. However saving any file would not auto compile. I then reverted all of my underscores and file endings, ran the task in the Task Runner and it worked but only momentarily. In either case, saving a partial is not compiling the base scss files.

The only way my files will compile at the moment is to save each base scss file or to save the compilerconfig.json file.

@madskristensen
Copy link
Owner

@sk5 A bug was recently fixed where .scss files that referenced partials (_partial.scss) but did so without using the underscore @import "partial"; didn't trigger recompile after the _partial.css file was updated. That should be fixed, but it might have had other side effects

@smartmeter
Copy link

Hi I have the same problem, the partial _variables.scss compiles fine, but the final style does not get compiled... reported a few weeks ago and I was testing... but it was closed #184

@Malyngo
Copy link

Malyngo commented Apr 5, 2016

This seems to be a tricky one.
I have this bug in one of my projects, while other run fine.

In this one project, the following happens when I am saving a partial:
In the status bar, it shows Compiling ..., some seconds later (seems longer than it should be) it changes to Ready, but the output css hasn't changed.

When I do changes in the main.scss with all my includes, also nothing happens.
When I right click the file in the_ Solution Explorer_, "Web Compiler" -> "Recompile file", nothing happens.
When I remove the file from the web compiler and re-add it, it compiles.

When I use the shortcut Alt+Shift+Y for "recompile all files in the solution", it works, css file gets updated.

If I can do anything to help you, check some stuff in my project or something, I am glad to help.

Something that might be unique to this project is that I created it with VS2013 and Web Essentials, and later updated to VS2015 and changed to Web Compiler.

@DaveRooney1
Copy link

This issue may link to the one I submitted recently. certainly sounds like they are linked.
#215.

I think this is a "other side effect" as described my madskristensen in the comment

@sk5 A bug was recently fixed where .scss files that referenced partials (_partial.scss) but did so without using the underscore @import "partial"; didn't trigger recompile after the _partial.css file was updated. That should be fixed, but it might have had other side effects

@DaveRooney1
Copy link

Ok, I figured it out.

Short answer:
Remove all comments that are on the same line as an @import within SASS files.

Long answer:
The SassDependencyResolver.cs class (method UpdateFileDependencies(string path)) has a regular expression that searches all sass files for @import text and uses the results to map what files that are dependent on each other. Unfortunately there is nothing that strips away comments that are on the same line as the @import text. so the regular expression would return the comment instead of the name of the sass file to import. I'm am not the best with Regular Expressions and have been trying to figure this issue out far too long. So I though I would pass on what I found so someone with better Regex knowledge could make the fix! any way hope this helps those that had the same issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants