Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandrill - Add ability to re-send emails on API errors #157

Open
ihor-sviziev opened this issue Mar 4, 2017 · 0 comments
Open

Mandrill - Add ability to re-send emails on API errors #157

ihor-sviziev opened this issue Mar 4, 2017 · 0 comments
Labels
enhancement

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Mar 4, 2017 •
edited
Loading

Hi,

We started using this module on our projects. Few times got error and as result email wasn't sent:

exception 'Mandrill_Error' with message 'We were unable to decode the JSON response from the Mandrill API: <html><body><h1>504 Gateway Time-out</h1>
The server didn't respond in time.
</body></html>

' in /my_project/magento/lib/Mandrill/Mandrill.php:156
Stack trace:
#0 /my_project/magento/lib/Mandrill/Mandrill/Senders.php(54): Mandrill_Mandrill->call('senders/domains', Array)
#1 /my_project/magento/app/code/community/Ebizmarts/MailChimp/Model/Email/Template.php(89): Mandrill_Senders->domains()
#2 /my_project/magento/app/code/core/Mage/Core/Model/Email/Template.php(508): Ebizmarts_MailChimp_Model_Email_Template->send(Array, Array, Array)
...

I know that these errors actually not related to your module, but I think this module could handle them better.

As a suggestion - would be great to separate server errors, connection errors and API errors (incorrect credentials, limit exceeded, etc.). In case of server errors - try to re-send request (would be great to have at least 3 attempts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@centerax @ihor-sviziev