Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII characters break HTTP server #558

Closed
smari opened this issue Apr 3, 2014 · 2 comments
Closed

Non-ASCII characters break HTTP server #558

smari opened this issue Apr 3, 2014 · 2 comments

Comments

@smari
Copy link
Contributor

smari commented Apr 3, 2014

Non-ASCII characters in Content-Disposition (i.e. attachment filenames) break HTTP server. Example: "Þetta er skráarnafn sem brýtur HTTP þjóninn.odt"

@thomwiggers
Copy link
Contributor

Apparently, it's hard to properly use non-ASCII headers to set the filename, and it's preferred to do it by appending the filename to the URL: http://stackoverflow.com/a/1365186/248065

EDIT: https://tools.ietf.org/html/rfc5987 is also relevant, it seems to be the most-supported alternative to using an actual filename in the URL.

I wouldn't classify this as 'low-hanging fruit' anymore...

@smari
Copy link
Contributor Author

smari commented Apr 14, 2014

Thanks for the info. I think it's still low hanging fruit, albeit slightly less low hanging. The definition of LHF for these purposes is something like "interesting but relatively narrow problem in scope, with few knock-on dependencies and relatively localized in the codebase"... i.e., easy to pick up without knowing the codebase, even if it's hard to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants