Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from arcticdb.util.test gives an error on Windows #1279

Closed
DrNickClarke opened this issue Jan 29, 2024 · 1 comment
Closed

Import from arcticdb.util.test gives an error on Windows #1279

DrNickClarke opened this issue Jan 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@DrNickClarke
Copy link
Collaborator

DrNickClarke commented Jan 29, 2024

Describe the bug

from arcticdb.util.test import random_strings_of_length

gives the error

`---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
Cell In[8], line 6
4 import random
5 import arcticdb as adb
----> 6 from arcticdb.util.test import random_strings_of_length

File ~\Python\s3_tests\s3_tests\lib\site-packages\arcticdb\util\test.py:13
11 import numpy as np
12 import pandas as pd
---> 13 import pytest
14 import string
15 import random

ModuleNotFoundError: No module named 'pytest'
`

Steps/Code to Reproduce

see above. Reproduced using arcticdb v4.2.1 on Windows.

Expected Results

No error is thrown

OS, Python Version and ArcticDB Version

Pyton 3.10, Windows 11, arcticdb 4.2.1

Backend storage used

Does not need storage to repro

Additional Context

The root cause is the function param_test https://github.com/man-group/ArcticDB/blob/master/python/arcticdb/util/test.py#L131

This function is only used by unit tests so should be moved to the unit test area of the project. Then import pytest can be removed from the main package.

The usages are in this file

@DrNickClarke DrNickClarke added the bug Something isn't working label Jan 29, 2024
@jamesmunro
Copy link
Collaborator

I think this was solved by your commit @DrNickClarke.
#1350
Can we close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants