Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VISUAL] Skyboxes are culled when looking away with a high enough FOV #305

Open
HoneyfrostStudio opened this issue Jun 22, 2024 · 3 comments
Labels
Bug Something isn't working

Comments

@HoneyfrostStudio
Copy link

Describe the bug

When the FOV exceeds 85, the skybox gets culled on the sides, revealing the void.

Steps to reproduce

Steps to reproduce the behavior:

  1. Modify the code to change minimum and maximum FOV values
  2. To better notice the issue, set your FOV to an absurdly high value, like 150.
  3. Observe

Fix

There's a fix for that; ficool2 talked about it a while ago on mapbase discord server:
https://discord.com/channels/548979532284297237/564519048503885845/782284538009092137

Media

Capture d'écran 2024-06-22 233911

@HoneyfrostStudio HoneyfrostStudio added the Bug Something isn't working label Jun 22, 2024
@meatspace
Copy link

yeah it can be fixed like this if blixi so chooses: momentum-mod/game#612

@Cvoxalury
Copy link

Hopefully Blixibon doesn't choose it, as it is truly insane - in essense guessing and patching what is assumed to be the right thing and assuming it won't cause any issues down the line. This kind of work is just too risky for Mapbase, like other proposed operations with memory hacks and patching things on the fly.

@WhiteRedDragons
Copy link

In my opinion this is pretty much a non-issue
The FOV Values are capped for a reason, you have to modify the safe min/max values to cause this to begin with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants