Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate duplicate style validation during style loading #3151

Closed
jfirebaugh opened this issue Sep 6, 2016 · 0 comments · Fixed by #3224
Closed

Eliminate duplicate style validation during style loading #3151

jfirebaugh opened this issue Sep 6, 2016 · 0 comments · Fixed by #3224
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@jfirebaugh
Copy link
Contributor

In looking into #2991, I noticed duplicate work being put into style validation on the main thread during startup. First, the entire style is validated via validateStyle(stylesheet). Then, each individual source, layer, and property is re-validated, via addSource and StyleLayer.create. The revalidation is unnecessary duplicate work. After validating the complete style up front, style loading should use code pathways for initializing sources and layers that don't perform the validation that are required by the public runtime styling APIs.

@jfirebaugh jfirebaugh added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Sep 6, 2016
@lucaswoj lucaswoj changed the title Duplicate style validation during style loading Eliminate duplicate style validation during style loading Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant