Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Annotation views on macOS #5035

Closed
1ec5 opened this issue May 14, 2016 · 2 comments
Closed

Annotation views on macOS #5035

1ec5 opened this issue May 14, 2016 · 2 comments
Labels
annotations Annotations on iOS and macOS or markers on Android archived Archived because of inactivity feature macOS Mapbox Maps SDK for macOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 14, 2016

The iOS and OS X versions of MGLMapView had nearly identical annotation implementations up until annotation views landed on iOS in #4801. @boundsj did a great job keeping the implementation clean, so porting it to OS X should mostly be a copy-paste job.

Along the way, it may be possible to directly share MGLAnnotationImage and MGLAnnotationView between the two SDKs in platform/darwin/ the way the other annotation classes are shared. The downside to sharing MGLAnnotationView would be limited Interface Builder support. We’d need to conditionally make MGLAnnotationView inherit from UIView on iOS and NSView on OS X with conditional compilation, yet IB lost the ability to understand preprocessor commands in Xcode 6.

@1ec5 1ec5 added feature macOS Mapbox Maps SDK for macOS labels May 14, 2016
@boundsj boundsj added the annotations Annotations on iOS and macOS or markers on Android label May 17, 2016
@1ec5 1ec5 changed the title Annotation views on OS X Annotation views on macOS Sep 26, 2016
@stale stale bot added the archived Archived because of inactivity label Nov 18, 2018
@stale
Copy link

stale bot commented Nov 20, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 20, 2018
@Zakalicious
Copy link

Am I correct that MGLAnnotationViews have not made it into the 0.15.1 release of the macos SDK?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android archived Archived because of inactivity feature macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

3 participants