Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Remove support for render(data, out, callback) in v4? #451

Closed
mlrawlings opened this issue Nov 29, 2016 · 2 comments
Closed

Question: Remove support for render(data, out, callback) in v4? #451

mlrawlings opened this issue Nov 29, 2016 · 2 comments
Assignees
@mlrawlings
Labels
scope:runtime
Milestone
4.0

Comments

@mlrawlings
Copy link
Member

We currently support the ability to pass both an out and a callback, however it's not documented and I'm not convinced it's necessary.

I'm adding a deprecation notice in v3 via #450 with a link to this issue, so hopefully we can get some feedback on whether this is something developers are using and actually need.

/cc @philidem
@mlrawlings mlrawlings added scope:runtime type:question A question about how to do something in Marko labels Nov 29, 2016
@mlrawlings mlrawlings added this to the 4.0 milestone Nov 29, 2016
@mlrawlings
Copy link
Member Author

We are using this in our tests, but it would be a simple change to go from this to out.on('finish')/out.on('error').

@mlrawlings
Copy link
Member Author

Closed via 9cbddca

@mlrawlings mlrawlings removed the type:question A question about how to do something in Marko label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlrawlings mlrawlings

Labels
scope:runtime
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@mlrawlings