Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Adonis/Addons/Throttle does have a extend method. Report this issue to the provider author > More details: https://err.sh/adonisjs/errors/E_INVALID_IOC_MANAGER #11

Closed
jericopulvera opened this issue Mar 4, 2019 · 7 comments

Comments

@jericopulvera
Copy link

InvalidArgumentException: E_INVALID_IOC_MANAGER: Make sure Adonis/Addons/Throttle does have a extend method. Report this issue to the provider author

More details: https://err.sh/adonisjs/errors/E_INVALID_IOC_MANAGER

at /Users/eco/Code/api.jericopulvera.com/server.js(anonymous):24
19
20 const { Ignitor } = require('@adonisjs/ignitor')
21
22 new Ignitor(require('@adonisjs/fold'))
23 .appRoot(__dirname)
24 .fireHttpServer()
25 .catch(console.error)

@masasron
Copy link
Owner

masasron commented Mar 4, 2019

@AndrewJo any ideas?

@jericopulvera
Copy link
Author

It's working before but now it's not. Maybe because of adonis update?

@Barry-Fisher
Copy link
Contributor

I came across this earlier today too.

I've been able to fix it locally so I've created a pull request that provides the fix and updates the associated test.

I've provided more detail in the PR: #12

Let's await feedback from the maintainers to see whether this PR is appropriate and whether they agree to merge it in.

Many thanks!

@AndrewJo
Copy link
Contributor

AndrewJo commented Mar 7, 2019

Oof. Just saw this now (just flew out for my wedding so haven't been checking my email) My bad guys. I should've tested it more thoroughly with a sample AdonisJs project. I'll review @Barryld's PR #12 and perhaps set up an integration test so we can catch things like this before it makes it into the codebase. Again, sorry and I take full responsibility for this bug.

@masasron
Copy link
Owner

masasron commented Mar 7, 2019

I've merged the fix, should be okay now 👍

@Barry-Fisher
Copy link
Contributor

Congratulations to @AndrewJo. I hope everything went well for you.

Bugs happen - it's just software. Life is more important. I hope you're not being too hard on yourself!

Thanks @masasron and @AndrewJo for attending to this and merging in the changes. Also, thanks for all your work on this project.

@masasron
Copy link
Owner

masasron commented Mar 8, 2019

Great work everyone!

Congratulations @AndrewJo 🎉 as @Barryld said it’s all good!

@masasron masasron closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants