Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Be more lenient when parsing oEmbed for URL previews #11063

Closed
squahtx opened this issue Oct 12, 2021 · 1 comment · Fixed by #11065
Closed

Be more lenient when parsing oEmbed for URL previews #11063

squahtx opened this issue Oct 12, 2021 · 1 comment · Fixed by #11065
Assignees
@clokep
Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@squahtx
Copy link
Contributor

squahtx commented Oct 12, 2021

Some popular websites don't conform to the letter of the oEmbed spec.
@squahtx squahtx added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Oct 12, 2021
@clokep clokep self-assigned this Oct 12, 2021
@clokep
Copy link
Member

clokep commented Oct 12, 2021

I think we probably want to allow it to be missing and assert that it is something similar to 1.0. I'll take a look at this.

@clokep clokep mentioned this issue Oct 12, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be more lenient when parsing the version for oEmbed responses. matrix-org/synapse
2 participants
@clokep @squahtx