Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Consider not purging "protected" files with media retention #12928

Closed
clokep opened this issue May 31, 2022 · 1 comment · Fixed by #12972
Closed

Consider not purging "protected" files with media retention #12928

clokep opened this issue May 31, 2022 · 1 comment · Fixed by #12972
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented May 31, 2022

From #12732:

Adds configuration options for automatically removing media if it hasn't been accessed (either locally or remotely) after a certain period of time.

It unfortunately doesn't take into account if the media is protected, which is usually applied to things like sticker packs (or maybe room avatars and such?). This feature was originally added specifically to avoid quarantining (see #4988 / #9083), but seems equally applicable to media retention feature in #6832.
@clokep clokep added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label May 31, 2022
@clokep
Copy link
Member Author

clokep commented May 31, 2022

CC @anoadragon453

@clokep clokep mentioned this issue May 31, 2022
Closed
@anoadragon453 anoadragon453 mentioned this issue Jun 6, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent local quarantined media from being claimed by media retention matrix-org/synapse
1 participant
@clokep