From 36901aef5661d4e42c91cc4495bb0c9f966421f5 Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Thu, 13 Apr 2023 12:17:39 +0100 Subject: [PATCH 1/2] Add missing comma --- synapse/storage/databases/main/event_federation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/storage/databases/main/event_federation.py b/synapse/storage/databases/main/event_federation.py index 9e6011e8ea18..2ad6fa7d5efe 100644 --- a/synapse/storage/databases/main/event_federation.py +++ b/synapse/storage/databases/main/event_federation.py @@ -1708,7 +1708,7 @@ def _delete_old_forward_extrem_cache_txn(txn: LoggingTransaction) -> None: WHERE stream_ordering < ? """ txn.execute( - sql, (self.stream_ordering_month_ago) # type: ignore[attr-defined] + sql, (self.stream_ordering_month_ago,) # type: ignore[attr-defined] ) await self.db_pool.runInteraction( From 6d6fcc98a239dffd564923e96cdec3103af88031 Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Thu, 13 Apr 2023 12:17:57 +0100 Subject: [PATCH 2/2] Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) --- changelog.d/15429.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/15429.misc diff --git a/changelog.d/15429.misc b/changelog.d/15429.misc new file mode 100644 index 000000000000..c5b054d19e72 --- /dev/null +++ b/changelog.d/15429.misc @@ -0,0 +1 @@ +Improve DB performance of clearing out old data from `stream_ordering_to_exterm`.