From a0f42ab3b59510ab6253e6b67595519d5f4203dc Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Thu, 7 May 2020 11:51:40 +0100 Subject: [PATCH 1/2] Remove unused store method get_hosts_in_room --- synapse/storage/data_stores/main/roommember.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/synapse/storage/data_stores/main/roommember.py b/synapse/storage/data_stores/main/roommember.py index d5bd0cb5cf26..ae9a76713c72 100644 --- a/synapse/storage/data_stores/main/roommember.py +++ b/synapse/storage/data_stores/main/roommember.py @@ -153,16 +153,6 @@ def _check_safe_current_state_events_membership_updated_txn(self, txn): self._check_safe_current_state_events_membership_updated_txn, ) - @cachedInlineCallbacks(max_entries=100000, iterable=True, cache_context=True) - def get_hosts_in_room(self, room_id, cache_context): - """Returns the set of all hosts currently in the room - """ - user_ids = yield self.get_users_in_room( - room_id, on_invalidate=cache_context.invalidate - ) - hosts = frozenset(get_domain_from_id(user_id) for user_id in user_ids) - return hosts - @cached(max_entries=100000, iterable=True) def get_users_in_room(self, room_id): return self.db.runInteraction( From 31308c3766e15cd268879a562f80ca1d3eebd4ef Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Thu, 7 May 2020 16:57:14 +0100 Subject: [PATCH 2/2] Add changelog --- changelog.d/7448.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/7448.misc diff --git a/changelog.d/7448.misc b/changelog.d/7448.misc new file mode 100644 index 000000000000..2163cc9b971d --- /dev/null +++ b/changelog.d/7448.misc @@ -0,0 +1 @@ +Remove storage method `get_hosts_in_room` that is no longer called anywhere. \ No newline at end of file