Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API endpoint exposing estimation gas scale factors #2257

Open
zeapoz opened this issue Jun 18, 2024 · 1 comment
Open

Add API endpoint exposing estimation gas scale factors #2257

zeapoz opened this issue Jun 18, 2024 · 1 comment

Comments

@zeapoz
Copy link

zeapoz commented Jun 18, 2024

🌟 Feature Request

📝 Description

Add an API endpoint that exposes the following environment variables:

  1. API_WEB3_JSON_RPC_ESTIMATE_GAS_SCALE_FACTOR
  2. API_WEB3_JSON_RPC_ESTIMATE_GAS_ACCEPTABLE_OVERESTIMATION
  3. API_WEB3_JSON_RPC_GAS_PRICE_SCALE_FACTOR

🤔 Rationale

In the era-test-node project, we've encountered an issue relating to the fact that the estimation gas scale factors we use are hardcoded. However, as these values differ between different networks and deployments we ideally need a way to dynamically procure these values from the upstream source.

@MexicanAce
Copy link
Contributor

This can be accomplished by updating the response object of zks_getFeeParams to include the following:

  • estimate_gas_scale_factor
  • estimate_gas_acceptable_overestimation
  • gas_price_scale_factor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants