Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade phpunit/php-code-coverage to 9.0 #15

Closed
nreynis opened this issue Sep 24, 2020 · 6 comments
Closed

Upgrade phpunit/php-code-coverage to 9.0 #15

nreynis opened this issue Sep 24, 2020 · 6 comments

Comments

@nreynis
Copy link

nreynis commented Sep 24, 2020

This package dependencies prevent upgrading to phpunit 9.3.
Being stuck with phpunit 9.2 is an issue because it also lock us away from PHP8.
@matthiasnoback
Copy link
Owner

Makes sense, can you make a PR?

@nreynis
Copy link
Author

nreynis commented Sep 25, 2020

I tried to give it a shot, but there's major BC in php-code-coverage.
I'm not familiar with previous version, so I'll have to understand what each method was doing and how it maps to the new API. If I have some time I'll try to dig further, but I can't promise anything.

@nreynis nreynis mentioned this issue Sep 26, 2020
Merged
@nreynis
Copy link
Author

nreynis commented Sep 26, 2020

Done!

@matthiasnoback
Copy link
Owner

Fixed by #16.

@matthiasnoback
Copy link
Owner

Thanks a lot Nicolas! I've added one other commit because I noticed that PHPUnit now has a FilterMapper that does the work of processing the files and directories etc. inside the config. So that saves us a few lines here.

@matthiasnoback
Copy link
Owner

By the way, I've released this as v1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthiasnoback @nreynis