Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image height should used in the bandwidth chooser instead of image width #58

Open
mash-graz opened this issue Mar 16, 2020 · 4 comments · May be fixed by #59
Open

image height should used in the bandwidth chooser instead of image width #58

mash-graz opened this issue Mar 16, 2020 · 4 comments · May be fixed by #59

Comments

@mash-graz
Copy link

Describe the bug

right now the bandwidth chooser in the right bottom of the player shows the image width instead of height for the variant entries in the HLS playlist. that's rather irritating, because all other players use the image height in this place. image height is also commonly used in the video tech world eg. to refer to FHD as "1080p" etc.

@matvp91
Copy link
Owner

matvp91 commented Mar 16, 2020

I went through the code and noticed that track.width is used in the UI to display a label for each video variant. See https://github.com/matvp91/indigo-player/blob/master/src/ui/components/Settings.tsx#L58

Would you mind filling in a PR or want me to take this one?

@mash-graz
Copy link
Author

if it would be a python or rust project, i would offer you a PR immediately, but unfortunately i'm not used to TS and all the mysteries of its build systems, although i could perhaps guess the right solution in this particular case by chance. ;)

@mash-graz mash-graz linked a pull request Mar 17, 2020 that will close this issue
@mash-graz
Copy link
Author

you'll now find a proposal to fix this issue in PR #59 beside eliminating some other flaws.

btw.: i really like your software and use it frequently in my own work!
e.g. https://gitlab.com/mur-at-public/live-video
thanks!

@matvp91
Copy link
Owner

matvp91 commented Mar 26, 2020

@mash-graz Thank you for your kind words! It looks pretty cool to see indigo in action in that screenshot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants