Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LMIC_clrTxData can clobber join #450

Closed
terrillmoore opened this issue Sep 11, 2019 · 1 comment
Closed

LMIC_clrTxData can clobber join #450

terrillmoore opened this issue Sep 11, 2019 · 1 comment
Assignees
@terrillmoore
Labels
bug

Comments

@terrillmoore
Copy link
Member

Calling LMIC_clrTxData at the wrong point in a join cycle can clobber the join. Don't clear TXRXPEND unless it's due to the TXDATA bit being set. This causes #445, because the compliance sketch was lucky enough to call at the wrong time.
@terrillmoore terrillmoore self-assigned this Sep 11, 2019
@terrillmoore
Copy link
Member Author

With this fix, things seem to be stable again (after the timing changes).

@terrillmoore terrillmoore mentioned this issue Sep 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore