Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With 0.2.1. printing a channel's info on join got a bit off.. #92

Closed
097115 opened this issue Nov 22, 2020 · 3 comments · Fixed by #94
Closed

With 0.2.1. printing a channel's info on join got a bit off.. #92

097115 opened this issue Nov 22, 2020 · 3 comments · Fixed by #94
Assignees
Labels
bug Something isn't working

Comments

@097115
Copy link

097115 commented Nov 22, 2020

Describe the bug

With 0.2.1, now prepending topic and names information with the channel's name on join, lines wrapping got a bit mangled:

  • 0.2.0:

020

  • 0.2.1

021

To Reproduce

  1. Run kirc in a relatively narrow window;
  2. Join a channel;
  3. Note that the first lines of topic and names commands now have the channel name prepended and their wrapping is incorrect.

Expected behavior

These new lines with channel names prepended should be wrapped in the same manner as all the other lines.

Additional context

Those -W and -w command line options were really nice, by the way :)

@mcpcpc mcpcpc self-assigned this Nov 22, 2020
@mcpcpc mcpcpc added the bug Something isn't working label Nov 22, 2020
@mcpcpc mcpcpc linked a pull request Nov 22, 2020 that will close this issue
@mcpcpc
Copy link
Owner

mcpcpc commented Nov 22, 2020

should be fixed with #94. getting late on my end, but will do some testing tomorrow to verify before merging.

Regarding the -w/-W arguments, i couldn’t really see a functional reason to keep them (other than aesthetics). i might consider adding the ability to adjust the ratio of nick to message length though.

@097115
Copy link
Author

097115 commented Nov 22, 2020

@mcpcpc Can confirm, 0.2.2 branch seems not to have this bug. Thanks!

(You will close this after merge?)

@mcpcpc
Copy link
Owner

mcpcpc commented Nov 22, 2020

since this issue is linked to the PR, it will automagically close on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants