Remove compile_flag from the schema (#3752)

mdn · Apr 9, 2019 · 2428be0 · 2428be0
1 parent 2401a76
commit 2428be0
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 32 deletions.
diff --git a/api/Document.json b/api/Document.json
@@ -5852,18 +5852,10 @@
             },
             "firefox": [
               {
-                "version_added": "61",
-                "version_removed": "63",
-                "flags": [
-                  {
-                    "type": "compile_flag",
-                    "name": "MOZ_BREAK_XUL_OVERLAYS",
-                    "value_to_set": "False"
-                  }
-                ],
+                "version_added": true,
+                "version_removed": "61",
                 "notes": [
                   "Available only to <a href='https://developer.mozilla.org/docs/Mozilla/Tech/XUL'>XUL documents</a>.",
-                  "If a XUL document attempts to load an overlay without the compile flag, an error will be thrown (see <a href='https://bugzil.la/1448162'>bug 1448162</a>).",
                   "See <a href='https://bugzil.la/1449791'>bug 1449791</a>"
                 ]
               },

diff --git a/javascript/operators/pipeline.json b/javascript/operators/pipeline.json
@@ -20,22 +20,10 @@
               "version_added": false
             },
             "firefox": {
-              "version_added": "58",
-              "flags": [
-                {
-                  "name": "--enable-pipeline-operator",
-                  "type": "compile_flag"
-                }
-              ]
+              "version_added": false
             },
             "firefox_android": {
-              "version_added": "58",
-              "flags": [
-                {
-                  "name": "--enable-pipeline-operator",
-                  "type": "compile_flag"
-                }
-              ]
+              "version_added": false
             },
             "ie": {
               "version_added": false

diff --git a/schemas/compat-data-schema.md b/schemas/compat-data-schema.md
@@ -305,7 +305,6 @@ array will have one item, but there are cases where two or more flags can be req
 An object in the `flags` array consists of three properties:
 * `type` (mandatory): an enum that indicates the flag type:
   * `preference` a flag the user can set (like in `about:config` in Firefox).
-  * `compile_flag` a flag to be set before compiling the browser.
   * `runtime_flag` a flag to be set before starting the browser.
 * `name` (mandatory): a string giving the value which the specified flag must be set to for this feature to work.
 * `value_to_set` (optional): representing the actual value to set the flag to.

diff --git a/schemas/compat-data.schema.json b/schemas/compat-data.schema.json
@@ -24,7 +24,7 @@
               "type": {
                 "type": "string",
                 "description": "An enum that indicates the flag type.",
-                "enum": ["preference", "compile_flag", "runtime_flag"]
+                "enum": ["preference", "runtime_flag"]
               },
               "name": {
                 "type": "string",

diff --git a/scripts/render.js b/scripts/render.js
@@ -185,10 +185,6 @@ function writeFlagsNote(supportData, browserId) {
     output += `${flagText} preference${valueToSet}. ${prefSettings}`;
   }
 
-  if (supportData.flag.type === 'compile_flag') {
-    output += `${flagText} compile flag${valueToSet}.`;
-  }
-
   return output;
 }
 

diff --git a/types.d.ts b/types.d.ts
@@ -160,10 +160,9 @@ export interface SimpleSupportStatement {
     /**
      * An enum that indicates the flag type:
      * - `preference` a flag the user can set (like in `about:config` in Firefox).
-     * - `compile_flag` a flag to be set before compiling the browser.
      * - `runtime_flag` a flag to be set before starting the browser.
      */
-    type: 'preference' | 'compile_flag' | 'runtime_flag';
+    type: 'preference' | 'runtime_flag';
 
     /**
      * A `string` representing the flag or preference to modify.