Meaningless "Promise-based version." notes for RTCPeerConnection #11158
Labels
data:api 🐇
Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
good first issue 💯
Good issues for getting started with this project.
Comments
foolip
added
the
data:api 🐇
foolip
added
the
good first issue 💯
|
Would the solution be to remove the note? |
|
Yep, most of those notes can go. A few methods originally didn't return a promise and for those they can stay. Then all browsers should have the note, most likely. |
|
I'm confused. Do we need to remove all the |
|
@AnilSeervi not quite, but all of the cases where Opera has these notes but Chrome doesn't are wrong and should be removed. |
foolip
pushed a commit
that referenced
this issue
Sep 23, 2021
This PR corrects the data throughout the RTCPeerConnection API, which was a **big** mess, mostly due to copy-paste error. The fixes include the following: - Converts the "Promise-based version" notes into subfeatures. It is more standard to use a subfeature rather than the notes. Additionally, they were copied and pasted all across the Opera data, so it caused some major data discrepancies. (Particularly, claiming support for features in Opera that weren't supported, wrong version numbers...) Fixes #11158. - Corrects the data regarding promise-based versions for Chrome. After further digging in, it turns out that most of these features had the wrong version number. New data comes from the commit history ([1](https://source.chromium.org/chromium/chromium/src/+/e16c96f5a5b517a64fdbc5be75f05e359e04b461), [2](https://source.chromium.org/chromium/chromium/src/+/70302a3d99ed149d59acf592edf9d32d4fd0dbda), [3](https://source.chromium.org/chromium/chromium/src/+/68f8e256dc7c7369127bd345100bcf776fa8acc0)). - Corrects the Samsung Internet and Opera/Opera Android data. In the case of Samsung Internet, it appears to have been set to 6.0 most everywhere after a mirroring from the old, incorrect wiki data (#1606), and Opera's data initially came from the wiki tables (#1070). When the Chrome data was corrected, however (see #3287), only the Chrome, Chrome Android, and WebView data was adjusted, leaving these other browsers untouched. - Corrects the version number for `createDataChannel` based upon results from the mdn-bcd-collector project (v3.3.0). - Finally, mirrors the Chrome data to both Chrome Android and WebView. Both had been left as `true` for many of the features, however since we have ranged values, we're able to replace the `true` with `≤37` for WebView, and mirror Chrome straight to Chrome Android since we know Chrome Android has supported this API back then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example:
browser-compat-data/api/RTCPeerConnection.json
Lines 105 to 114 in 2d29a84
This is a note for the
new RTCPeerConnection()constructor, and makes no sense. This seems to be have copied and spread around at some point, and only partially clean up.The text was updated successfully, but these errors were encountered: