Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and complete RTCPeerConnection #1288

Closed
Elchi3 opened this issue Mar 6, 2018 · 5 comments
Closed

Update and complete RTCPeerConnection #1288

Elchi3 opened this issue Mar 6, 2018 · 5 comments
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API good first issue 💯 Good issues for getting started with this project. help wanted 🆘 You're encouraged to pick up this issue, a maintainer will come back to you and review your work.

Comments

@Elchi3
Copy link
Member

Elchi3 commented Mar 6, 2018

There has been a massive PR to add RTCPeerConnection (#1070), a few things were left out which we should add:
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/close
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/addTransceiver
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/currentRemoteDescription
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/iceGatheringState
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/onicecandidateerror

(we could also wait until we've initially updated the MDN pages [which will happen soon] and then update/correct this file for other issues found.)
@Elchi3 Elchi3 added help wanted 🆘 You're encouraged to pick up this issue, a maintainer will come back to you and review your work. data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Mar 6, 2018
@jlaine
Copy link
Contributor

jlaine commented Mar 30, 2018

It looks as though there was some unfortunate copy-and-paste somewhere, for instance I noticed that the information about RTCPeerConnection.getSenders was not correct, see #1713. I'll check if I find any other errors.

@jlaine
Copy link
Contributor

jlaine commented Mar 30, 2018

RTCPeerConnection.getReceivers was also wrong, see #1714.

julfers pushed a commit to julfers/browser-compat-data that referenced this issue Apr 30, 2018
Fix Chrome/Opera versions RTCPeerConnection.addTrack/removeTrack (mdn…
9ab09f5 
…#1288)
@julfers
Copy link
Contributor

julfers commented Apr 30, 2018

RTCPeerConnection.addTrack() and RTCPeerConnection.removeTrack() had the same error as getSenders() see #1963

Elchi3 pushed a commit that referenced this issue May 2, 2018
@julfers @Elchi3
Fix Chrome/Opera versions RTCPeerConnection.addTrack/removeTrack (#1288…
8ece06e 
…) (#1963)
@connorshea connorshea mentioned this issue Jun 14, 2018
Merged
@Elchi3
Copy link
Member Author

Elchi3 commented Aug 10, 2018

Looks like there is only https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/currentRemoteDescription#Browser_compatibility left to migrate here.

@Elchi3 Elchi3 added the good first issue 💯 Good issues for getting started with this project. label Aug 10, 2018
@Elchi3
Copy link
Member Author

Elchi3 commented Sep 9, 2018

This was fixed in #2662

@Elchi3 Elchi3 closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API good first issue 💯 Good issues for getting started with this project. help wanted 🆘 You're encouraged to pick up this issue, a maintainer will come back to you and review your work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Elchi3 @jlaine @julfers