Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentRequest.p.paymentAddress → shippingAddress #7669

Merged
merged 2 commits into from
Jan 14, 2021
Merged

PaymentRequest.p.paymentAddress → shippingAddress #7669

merged 2 commits into from
Jan 14, 2021

Conversation

sideshowbarker
Copy link
Collaborator

This change renames the BCD paymentAddress subfeature of the PaymentRequest feature to shippingAddress.

As noted in #7668, it’s been PaymentRequest.prototype.shippingAddress “for years, probably from the start”.

cc @marcoscaceres for confirmation

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 13, 2020
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/PaymentRequest-shippingAddress-rename branch from 0cc54d9 to a641305 Compare December 13, 2020 04:05
@sideshowbarker
PaymentRequest.p.paymentAddress → shippingAddress
5fb471f 
This change renames the BCD paymentAddress subfeature of the
PaymentRequest feature to shippingAddress.

As noted in mdn#7668, it’s
been PaymentRequest.prototype.shippingAddress “for years, probably from
the start”.

Fixes mdn#7668
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/PaymentRequest-shippingAddress-rename branch from a641305 to 5fb471f Compare December 13, 2020 04:25
saschanaz
saschanaz reviewed Dec 13, 2020
View reviewed changes
api/PaymentRequest.json Outdated Show resolved Hide resolved
@sideshowbarker @saschanaz
Apply suggestions from code review
e4c2dab 
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/PaymentRequest-shippingAddress-rename branch from f414d42 to e4c2dab Compare December 14, 2020 08:01
ddbeck
ddbeck approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Do you want to wait for Marcos's confirmation before merging?

@foolip
Copy link
Collaborator

foolip commented Jan 14, 2021

Marcos has an away status, so I would suggest not waiting.

@ddbeck ddbeck merged commit b507e99 into mdn:master Jan 14, 2021
@sideshowbarker sideshowbarker deleted the sideshowbarker/PaymentRequest-shippingAddress-rename branch January 21, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz left review comments

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sideshowbarker @foolip @ddbeck @saschanaz @queengooborg