Updates for Safari 14.1 on macOS and Safari on iOS 14.5 #10129

jdatapple · 2021-04-27T18:51:19Z

This is a large update of features supported with the release of Safari 14.1 on macOS and Safari on iOS 14.5. The changes have been compiled using mdn-results-collector, a thorough review of changes by the WebKit engineering team at Apple, manual tests to verify results, and engineer submissions.

foolip · 2021-04-28T07:21:37Z

css/properties/gap.json

@@ -33,10 +33,10 @@
                "version_added": false
              },
              "safari": {
-                "version_added": false
+                "version_added": "14.1"


Yes! Thanks to @svillar for closing the gap in flexbox 🎉

foolip

I've reviewed some of the trickier bits, I'll come back to review all the other changes after upgrading to macOS 11.3 :)

test/linter/test-versions.js

api/AudioListener.json

api/AudioContext.json

api/OfflineAudioContext.json

foolip · 2021-04-28T08:16:08Z

browsers/safari.json

@@ -173,6 +173,19 @@
          "status": "current",
          "engine": "WebKit",
          "engine_version": "610.1.28"
+        },
+        "14.0.2": {


See #8838 for a previous discussion on how to handle MediaRecorder and iOS 14.3. The conclusion then was to treat it as a minor version and live with a little bit of inaccuracy in the data.

But if the Safari teams considers these versions significant and would like to add them, that's a decision that should be revisited. cc @ddbeck @Elchi3

Yeah, that pretty well summarizes it, but I can add some additional detail:

https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#release-lines-and-backported-is our best effort to document our thinking with which versions to include. If I were writing it today, I'd probably add some text which speaks to the question: will web developers be making a distinction between version X and version Y version in a year or two?

(I think during a call back in March, it was suggested that that 14.0.3 was a significant release, but there wasn't really a story for testing the difference between it and other 14.0.x versions. This suggested to me that developers won't make the distinction either. I'd expect similar problems for any 14.0.x.)

We are opting for fudging this data and using "14" in cases where 14.0.2 appear or safari_ios shows 14.3.

api/AnalyserNode.json

api/AudioParam.json

api/AudioParamMap.json

api/OfflineAudioContext.json

api/OscillatorNode.json

api/PannerNode.json

foolip · 2021-04-28T11:13:19Z

Oops, I submitted that review too early by accident. The rest is coming in a second batch :)

Helps with mdn/browser-compat-data#10129.

foolip

OK, I've gotten through all of api/ now. Taking a break, because this was very time consuming :)

I anyone else wants to review css/ and later in detail, that would be great.

api/PerformanceNavigation.json

api/RTCPeerConnection.json

api/RTCPeerConnectionIceErrorEvent.json

api/StereoPannerNode.json

api/VTTCue.json

api/_mixins/ParentNode__Document.json

api/_mixins/ParentNode__DocumentFragment.json

api/_mixins/ParentNode__Element.json

foolip · 2021-04-28T11:56:08Z

OK, with this many review comments I realize it's going to be hard to make sense of. To summarize the state of the API data, there are a bunch of minor errors that I've suggested fixes for, and one interesting decision to be made about whether to have "14.0.2" and "14.3" as their own versions.

@apple-web-evangelist some of my comments are just confirming support or noting something interesting. Feel free to resolve those when you've read them to get them out of the way. Also note that GitHub will unhelpfully hide comments when there are lots of them, so somewhere in the middle there will be "Load more..." links to click.

ddbeck · 2021-04-28T12:07:00Z

I anyone else wants to review css/ and later in detail, that would be great.

@foolip Thank you so much for taking on a big chunk of the work here. Makes this PR feel a lot smaller. 😄 I'll take a look at the CSS (and the interesting decision stuff) more closely later today. 👍

json-derulo · 2021-04-28T14:57:24Z

Intl.DisplayNames was also added with Safari 14.1. I've created a separate PR for this (#10130), but maybe it makes sense to add it to this PR instead.

jonathandavis · 2021-04-28T15:20:21Z

This is all great feedback. I'm working through incorporating the suggested changes based on your findings @foolip. Thanks for the additional verification.

@json-derulo Also a good catch! I will incorporate that change as part of this PR as well.

robpalme · 2021-04-28T16:38:01Z

This looks good. I had earlier created a PR for JavaScript classes which also included updates to "static" and "static fields" sub-features which are currently missing from this PR.

jdatapple · 2021-04-28T16:51:46Z

This is all great feedback. I'm working through incorporating the suggested changes based on your findings @foolip. Thanks for the additional verification.

@json-derulo Also a good catch! I will incorporate that change as part of this PR as well.

In addition, there is also data missing for Intl.DateTimeFormat and Intl.NumberFormat updates. Support for Intl.ListFormat and Intl.Segmenter are also available in these releases.

In the case of Intl.Segmenter there is a page, but currently no data file. Is there existing/formal process for requesting or generating a new file?

api/MediaMetadata.json

api/MediaRecorder.json

ddbeck · 2021-04-28T16:13:07Z

browsers/safari.json

@@ -173,6 +173,19 @@
          "status": "current",
          "engine": "WebKit",
          "engine_version": "610.1.28"
+        },
+        "14.0.2": {


Yeah, that pretty well summarizes it, but I can add some additional detail:

https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#release-lines-and-backported-is our best effort to document our thinking with which versions to include. If I were writing it today, I'd probably add some text which speaks to the question: will web developers be making a distinction between version X and version Y version in a year or two?

(I think during a call back in March, it was suggested that that 14.0.3 was a significant release, but there wasn't really a story for testing the difference between it and other 14.0.x versions. This suggested to me that developers won't make the distinction either. I'd expect similar problems for any 14.0.x.)

api/WEBGL_compressed_texture_pvrtc.json

api/WebGLRenderingContext.json

css/properties/aspect-ratio.json

css/properties/scroll-margin-bottom.json

javascript/classes.json

webextensions/manifest/background.json

jdatapple · 2021-04-28T17:37:45Z

Performing another pass to address @ddbeck's comments.

lukewarlow · 2021-04-28T19:18:19Z

With regards to the new date/time input support. You don't appear to have changed the time input to show it's supported as of Safari 14.1.

jdatapple · 2021-04-28T19:29:40Z

A follow-up commit will include it. Thank you for pointing it out that it didn't make it into our the data.

lukewarlow · 2021-04-28T19:30:48Z

css/properties/aspect-ratio.json

@@ -69,7 +69,7 @@
              "version_added": false
            },
            "safari_ios": {
-              "version_added": false
+              "version_added": "14.5"


The aspect ratio experimental feature is disabled for me on both macOS and iOS. Is this not the case for others?

https://mdn-bcd-collector.appspot.com/tests/css/properties/aspect-ratio shows support for me on iOS 14.5, but feature detection can be broken.

Some of the basic test cases in https://wpt.live/css/css-sizing/aspect-ratio/ aren't passing, so I think most likely the property is recognized but the actual behavior is gated by a flag.

I verified that this is just wrong.

Addressed in 90183cb.

And I've updated mdn-bcd-collector in a way to avoid the WebKit bug leading to this false positive in foolip/mdn-bcd-collector#1132.

Confirmed with https://mdn-bcd-collector.appspot.com/tests/api/OfflineAudioContext in Safarai 14.1. This was missed in #10129.

Updates for Safari 14.1 on macOS and Safari on iOS 14.5

ce5dff5

jdatapple requested a review from ddbeck as a code owner April 27, 2021 18:51

github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 27, 2021

foolip reviewed Apr 28, 2021

View reviewed changes

foolip mentioned this pull request Apr 28, 2021

Mark webkitOfflineAudioContext supported in Safari / iOS 6 #10137

Closed

foolip reviewed Apr 28, 2021

View reviewed changes

ddbeck added data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. labels Apr 28, 2021

foolip reviewed Apr 28, 2021

View reviewed changes

foolip added a commit to foolip/mdn-bcd-collector that referenced this pull request Apr 28, 2021

Use webkitSpeechRecognition to test SpeechRecognition members

f173f78

Helps with mdn/browser-compat-data#10129.

foolip mentioned this pull request Apr 28, 2021

Use webkitSpeechRecognition to test SpeechRecognition members foolip/mdn-bcd-collector#1130

Merged

foolip added a commit to foolip/mdn-bcd-collector that referenced this pull request Apr 28, 2021

Use webkitSpeechRecognition to test SpeechRecognition members (#1130)

2aab647

Helps with mdn/browser-compat-data#10129.

foolip reviewed Apr 28, 2021

View reviewed changes

ddbeck requested changes Apr 28, 2021

View reviewed changes

Follow-up to address suggested changes

2d299ed

json-derulo mentioned this pull request Apr 28, 2021

Add Safari 14.1 support for Intl.DisplayNames #10130

Closed

lukewarlow mentioned this pull request Apr 28, 2021

Add Safari 14.1 support for input type, date, datetime-local and time. #10096

Closed

lukewarlow reviewed Apr 28, 2021

View reviewed changes

jdatapple added 2 commits April 28, 2021 21:12

Additional follow-up to address review comments

90183cb

Add newtab support in Safari 14.1

470bd79

ddbeck merged commit 0b36b4a into mdn:main Apr 29, 2021

jdatapple deleted the safari-14.1-pr branch April 29, 2021 18:57

This was referenced Apr 30, 2021

html.elements.input.input-date - Safari 14.1 now supports input type date #10174

Closed

css.properties.translate - mark as available on safari 14.1 #10172

Closed

queengooborg mentioned this pull request Apr 30, 2021

css.properties.scroll-margin - Safari compatibilty has improved #10160

Closed

lukewarlow mentioned this pull request Apr 30, 2021

Update TransformStream for Safari Desktop/Mobile #10169

Closed

1 task

kangzj mentioned this pull request May 2, 2021

api.Element.scrollTo - Safari 14.1 supports options #10222

Closed

This was referenced May 4, 2021

Safari does not support scroll-margin #4945

Closed

Navbar covers text ImageMagick/Website#67

Closed

foolip added a commit that referenced this pull request May 5, 2021

Mark OfflineAudioContext's resume() shipped in Safari 14.1

bd6ca03

Confirmed with https://mdn-bcd-collector.appspot.com/tests/api/OfflineAudioContext in Safarai 14.1. This was missed in #10129.

foolip mentioned this pull request May 5, 2021

Mark OfflineAudioContext's resume() shipped in Safari 14.1 #10285

Merged

This was referenced May 6, 2021

Desktop Safari adds date/time input support in v14.1 #9351

Closed

Add Intl.NumberFormat Unified API support in Safari 14.1 #9315

Closed

ddbeck pushed a commit that referenced this pull request May 17, 2021

Mark OfflineAudioContext's resume() shipped in Safari 14.1 (#10285)

ed13bb6

Confirmed with https://mdn-bcd-collector.appspot.com/tests/api/OfflineAudioContext in Safarai 14.1. This was missed in #10129.

ddbeck mentioned this pull request May 25, 2021

api.Blob.text - Supported in Safari at least 14+ #9791

Closed

lukewarlow mentioned this pull request Jun 1, 2021

Add implementation_url to WritableStream in Safari #7417

Closed

foolip mentioned this pull request Jun 10, 2021

Update Safari versions for VRPose API #10927

Closed

jdatapple mentioned this pull request Jun 25, 2021

Add Safari 15 support for MediaMetadata #11249

Merged

queengooborg mentioned this pull request Dec 24, 2021

html.elements.input.input-date - Not working in safari #10419

Closed

jdatapple mentioned this pull request Feb 10, 2022

Add Safari referrerpolicy attribute support #14923

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for Safari 14.1 on macOS and Safari on iOS 14.5 #10129

Updates for Safari 14.1 on macOS and Safari on iOS 14.5 #10129

jdatapple commented Apr 27, 2021

foolip Apr 28, 2021

foolip left a comment

foolip Apr 28, 2021

ddbeck Apr 28, 2021

jdatapple Apr 28, 2021 •

edited

Loading

foolip commented Apr 28, 2021

foolip left a comment

foolip commented Apr 28, 2021

ddbeck commented Apr 28, 2021

json-derulo commented Apr 28, 2021

jonathandavis commented Apr 28, 2021

robpalme commented Apr 28, 2021

jdatapple commented Apr 28, 2021

ddbeck Apr 28, 2021

jdatapple commented Apr 28, 2021

lukewarlow commented Apr 28, 2021

jdatapple commented Apr 28, 2021

lukewarlow Apr 28, 2021

foolip Apr 28, 2021

jdatapple Apr 28, 2021

jdatapple Apr 28, 2021

foolip Apr 29, 2021

Updates for Safari 14.1 on macOS and Safari on iOS 14.5 #10129

Updates for Safari 14.1 on macOS and Safari on iOS 14.5 #10129

Conversation

jdatapple commented Apr 27, 2021

Choose a reason for hiding this comment

foolip left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdatapple Apr 28, 2021 • edited Loading

Choose a reason for hiding this comment

foolip commented Apr 28, 2021

foolip left a comment

Choose a reason for hiding this comment

foolip commented Apr 28, 2021

ddbeck commented Apr 28, 2021

json-derulo commented Apr 28, 2021

jonathandavis commented Apr 28, 2021

robpalme commented Apr 28, 2021

jdatapple commented Apr 28, 2021

Choose a reason for hiding this comment

jdatapple commented Apr 28, 2021

lukewarlow commented Apr 28, 2021

jdatapple commented Apr 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdatapple Apr 28, 2021 •

edited

Loading