Sort out FetchEvent data #10774
Merged
Sort out FetchEvent data #10774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an unusual amount wrong here... The current state of things in source: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/service_worker/fetch_event.idl;drc=fc05b522c6d4a85354c9d6f39b76c3d7f8448b68 https://github.com/mozilla/gecko-dev/blob/a4c86edb340aeee2b91a2ab617c66cb4ea7b7b66/dom/webidl/FetchEvent.webidl https://github.com/WebKit/WebKit/blob/af262cabe3e5b067a177fb4203a7112f14028092/Source/WebCore/workers/service/FetchEvent.idl The client attribute is removed as irrelevant as it actually never shipped in Chrome, it was landed and reverted in 2015 and didn't reach stable, and was removed in Gecko in 2015 before FetchEvent shipped: https://chromium.googlesource.com/chromium/src/+/4e79b14a361c3960c11a2139df74a315b915c740 https://chromium.googlesource.com/chromium/src/+/ade5cc571923215463317b3212f7a50683f79038 mozilla/gecko-dev@7029e80 The navigationPreload attribute was the original name for preloadResponse, but was renamed in Chromium before it reached stable: https://chromium.googlesource.com/chromium/src/+/111601216214188fc2ace390da5b2af0095564fd https://chromium.googlesource.com/chromium/src/+/95d26e23d47ff912eefe1d1caa7dc67552b3ffae The preloadResponse attribute isn't in Gecko/WebKit source, see above. The replacesClientId attribute turns out to not be in the source of any engine (see above) and test shows it actually wasn't in Edge 18 either: https://mdn-bcd-collector.appspot.com/tests/api/FetchEvent/replacesClientId As a minor error, the resultingClientId attribute also wasn't in Edge 18: https://mdn-bcd-collector.appspot.com/tests/api/FetchEvent/resultingClientId Finally, the targetClientId was shipped in Safari, but in the spec it was renamed to replacesClientId (see above) which hasn't shipped in any browser: w3c/ServiceWorker#1333 Nevertheless, treat Safari's targetClientId as an alternative name for replacesClientId to combine the entries.
github-actions
bot
added
the
data:api 🐇
|
A content update will also be needed for this, I realize. |
queengooborg
added
the
needs content update 📝
foolip
added a commit
to foolip/content
that referenced
this pull request
Jun 18, 2021
Goes with mdn/browser-compat-data#10774. https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent is in good shape and doesn't need updating.
|
I've sent mdn/content#6115 for MDN. |
foolip
removed
the
needs content update 📝
sideshowbarker
pushed a commit
to mdn/content
that referenced
this pull request
Jun 18, 2021
Goes with mdn/browser-compat-data#10774. https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent is in good shape and doesn't need updating.
sideshowbarker
approved these changes
Jun 19, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 24, 2021
ddbeck
added a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unusual amount wrong here...
The current state of things in source:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/service_worker/fetch_event.idl;drc=fc05b522c6d4a85354c9d6f39b76c3d7f8448b68
https://github.com/mozilla/gecko-dev/blob/a4c86edb340aeee2b91a2ab617c66cb4ea7b7b66/dom/webidl/FetchEvent.webidl
https://github.com/WebKit/WebKit/blob/af262cabe3e5b067a177fb4203a7112f14028092/Source/WebCore/workers/service/FetchEvent.idl
The client attribute is removed as irrelevant as it actually never
shipped in Chrome, it was landed and reverted in 2015 and didn't reach
stable, and was removed in Gecko in 2015 before FetchEvent shipped:
https://chromium.googlesource.com/chromium/src/+/4e79b14a361c3960c11a2139df74a315b915c740
https://chromium.googlesource.com/chromium/src/+/ade5cc571923215463317b3212f7a50683f79038
mozilla/gecko-dev@7029e80
The navigationPreload attribute was the original name for
preloadResponse, but was renamed in Chromium before it reached stable:
https://chromium.googlesource.com/chromium/src/+/111601216214188fc2ace390da5b2af0095564fd
https://chromium.googlesource.com/chromium/src/+/95d26e23d47ff912eefe1d1caa7dc67552b3ffae
The preloadResponse attribute isn't in Gecko/WebKit source, see above.
The replacesClientId attribute turns out to not be in the source of any
engine (see above) and test shows it actually wasn't in Edge 18 either:
https://mdn-bcd-collector.appspot.com/tests/api/FetchEvent/replacesClientId
As a minor error, the resultingClientId attribute also wasn't in Edge 18:
https://mdn-bcd-collector.appspot.com/tests/api/FetchEvent/resultingClientId
Finally, the targetClientId was shipped in Safari, but in the spec it
was renamed to replacesClientId (see above) which hasn't shipped in any
browser: w3c/ServiceWorker#1333
Nevertheless, treat Safari's targetClientId as an alternative name for
replacesClientId to combine the entries.