Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant api.HTMLFrameSetElement.event_handlers feature #11459

Merged

Conversation

queengooborg
Copy link
Collaborator

This PR removes api.HTMLFrameSetElement.event_handlers from our data. Since the API doesn't define its own event handlers as the MDN article states (and I question whether this API actually has an onstorage event handler), there's no reason to have this feature around.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 9, 2021
@foolip
Copy link
Collaborator

foolip commented Jul 11, 2021

Per https://html.spec.whatwg.org/multipage/obsolete.html#htmlframesetelement this interface does include the WindowEventHandlers mixin, so this isn't all fiction. I'm not sure we should add all of those entries though...

@ddbeck for thoughts.

@ddbeck ddbeck self-requested a review July 21, 2021 16:10
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should have the mixin-originating features too. If you want to make that happen, then great, but if you'd rather open an issue saying that it ought to be done eventually and merge this as-is, I'm fine with that too.

@queengooborg
Copy link
Collaborator Author

Since we still need to demix the WindowEventHandlers mixin, I've opened up an issue (see #11675) to document what we should do. I'd like to merge this as-is for now!

@foolip foolip merged commit 1e2d1da into mdn:main Jul 23, 2021
@queengooborg queengooborg deleted the api/HTMLFrameSetElement/event_handlers/removal branch July 23, 2021 23:24
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 29, 2021
ddbeck added a commit that referenced this pull request Jul 29, 2021
* Bump version to v3.3.13

* Add release note for #11717

* Add release note for #11753

* Add release note for #11459

* Add release note for #11720

* Add release note for #11722

* Add release note for #11721

* Add release note for #11763

* Add release note for #10623

* Add release note for #11000

* Add stats and release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants