Update Chromium versions for RTCDataChannel API #12293
Conversation
This PR updates and corrects the real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `RTCDataChannel` API, based upon both commit history and results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.12). Commit-based data: https://source.chromium.org/chromium/chromium/src/+/ce4f330106a77d5f5c2a5b4d7b7abbb1bf7a299e (Chrome 24 (mirrored from RTCPeerConnection.createDataChannel): RTCDataChannel, label, reliable, readyState, bufferedAmount, binaryType, send, close, onopen, onerror, onclose, onmessage, open_event, error_event, close_event, message_event) https://source.chromium.org/chromium/chromium/src/+/138b48a5d343fa8688ecf5ee120edd2e8a8841b9 (Chrome 30 (based upon feature freeze date of Jul 26, 2013): ordered, maxRetransmits, protocol, negotiated, id) All other changes: https://mdn-bcd-collector.appspot.com/tests/api/RTCDataChannel
github-actions
bot
added
the
data:api 🐇
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/createDataChannel#browser_compatibility says Chrome 25, so this doesn't seem to be copied from that data. Which is correct?
Can some (all?) of these be confirmed by the collector, so that we don't need to worry about getting the date wrong and being off by one version? |
|
Ah, I had run I've also been having a problem with the test for this API in early versions of Chrome, which is why I elected to use Chrome's source code. |
|
Do you want to update it in #12300? I'll hold off until the change is in some other PR at least. |
|
Done! |
This PR updates and corrects the real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
RTCDataChannelAPI, based upon both commit history and results from the mdn-bcd-collector project (v3.2.12).Commit-based data:
https://source.chromium.org/chromium/chromium/src/+/ce4f330106a77d5f5c2a5b4d7b7abbb1bf7a299e (Chrome 25 (mirrored from RTCPeerConnection.createDataChannel): RTCDataChannel, label, reliable, readyState, bufferedAmount, binaryType, send, close, onopen, onerror, onclose, onmessage, open_event, error_event, close_event, message_event)
https://source.chromium.org/chromium/chromium/src/+/138b48a5d343fa8688ecf5ee120edd2e8a8841b9 (Chrome 30 (based upon feature freeze date of Jul 26, 2013): ordered, maxRetransmits, protocol, negotiated, id)
All other changes: https://mdn-bcd-collector.appspot.com/tests/api/RTCDataChannel