-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct data for the RTCPeerConnection API #12300
Correct data for the RTCPeerConnection API #12300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptions for all returns_promise
entries need updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A big PR, unfortunately it's easy to find more things wrong with the data on each pass. However, I promise that with this round, if I find even more next time, I'll file follow-up issues for the rest instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed everything again and can't spot any more issues. Thanks for sorting out this huge mess, this is much, much better now! 🥳
@ddbeck I think the new subfeatures for promises are release note worthy. |
@foolip Good idea. In the forthcoming release notes, I've included this with the text for #11630. If you want to review today before the release, that would be helpful (but not required). |
* Bump version to v4.0.5 * Bump known issues * Add release note for #12417 * Add release note for #12454 * Add release note for #12417 * Add release note for #12346 * Add release note for #12455 * Add release note for #12518 * Add release note for #11630 * Add release note for #12300 * Add release note for #12552 * Add release stats * Add release date * Fix a typo
@ddbeck I've reviewed the release notes after the fact, looks good, thank you! |
This PR corrects the data throughout the RTCPeerConnection API, which was a big mess, mostly due to copy-paste error. The fixes include the following:
Add data regarding the prefixed constructorThis one was done in Represent support for webkitRTCPeerConnection #12196 already, though the non-prefixed version number was a little off based on my testing, so this is a quick correction.Updates the notes regarding the defaultCherry-picked in Update notes regarding default value of an RTCPeerConnection option #12301.rtcpMuxPolicy
value in Chrome when constructing a new instance. The notes didn't mention what the new default value is, which is slightly unhelpful. (There's only two values available, but the note update removes the need to scroll up on the page and find that out.)createDataChannel
based upon results from the mdn-bcd-collector project (v3.3.0).true
for many of the features, however since we have ranged values, we're able to replace thetrue
with≤37
for WebView, and mirror Chrome straight to Chrome Android since we know Chrome Android has supported this API back then.There's a lot of changes made in this PR, so I would love to get it reviewed and merged ASAP!