Remove the "type and listener parameters are optional" feature #13143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the inversion of the non-standard "feature" that the following
don't throw an exception but instead do nothing:
```js
window.addEventListener()
window.addEventListener('load')
```
That "feature" has been removed from all browsers, confirmed by manually
testing whether `window.addEventListener('load')` throws.
Notably, it did throw in Edge 18. Exactly when the parameters were made
required in Chrome, Firefox and Safari hasn't been tested. It was
probably long ago, but ultimately it doesn't matter, since the "feature"
here is not a feature at all, just a quirk that was only important at
the moment it was being fixed, when it could have broken sites.
github-actions
bot
added
the
data:api 🐇
lucalves
approved these changes
Oct 29, 2021
queengooborg
approved these changes
Nov 1, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Nov 2, 2021
ddbeck
added a commit
that referenced
this pull request
Nov 2, 2021
* Bump version to v4.0.9 * Set release date * Add release note for #12795 * Add release note for #13006 * Add release note for #13136 * Add release note for #13076 * Add release note for #13216 * Add release note for #11924 * Add release note for #13143 * Undo list of one item * Hoist known issues * Add stats * Fix compare link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the inversion of the non-standard "feature" that the following
don't throw an exception but instead do nothing:
That "feature" has been removed from all browsers, confirmed by manually
testing whether
window.addEventListener('load')throws.Notably, it did throw in Edge 18. Exactly when the parameters were made
required in Chrome, Firefox and Safari hasn't been tested. It was
probably long ago, but ultimately it doesn't matter, since the "feature"
here is not a feature at all, just a quirk that was only important at
the moment it was being fixed, when it could have broken sites.