Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real values for all MathML features #3590

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Add real values for all MathML features #3590

merged 3 commits into from
Mar 25, 2019

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Mar 8, 2019

The first two commits indicate no MathML support at all in Edge or Edge Mobile
See https://developer.microsoft.com/en-us/microsoft-edge/platform/status/mathml/

The third commit also updates the few Firefox and Safari values with real values.

With this PR, 100% of the data in the mathml/ folder has real values for the 8 tracked browsers.

Overall, it changes the stats a bit as well:

Before (current master):

browser real values true values null values
total 55.26% 22.23% 22.51%
edge 53.23% 20.25% 26.53%

After this PR:

browser real values true values null values
total 55.49% 22.20% 22.32%
edge 54.83% 20.25% 24.93%

@Elchi3 Elchi3 added the data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML label Mar 8, 2019
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it’s not supported on Desktop, then it’s definitely not supported on Mobile.

@Elchi3 Elchi3 changed the title MathML is not supported in Edge Add real values for all MathML features Mar 19, 2019
@Elchi3
Copy link
Member Author

Elchi3 commented Mar 19, 2019

Thanks @ExE-Boss, I've updated the PR.

@Elchi3
Copy link
Member Author

Elchi3 commented Mar 19, 2019

Maybe @fred-wang can help reviewing or knows someone who could.
(the Safari and Firefox changes which are in the 3rd commit).

@fred-wang
Copy link
Contributor

IIUC Microsoft Edge uses different web engines on mobile (e.g. blink on android and webkit on iOS). Also Microsoft plans to switch to blink on Windows too, so that would mean the same result as Chrome ( https://blogs.windows.com/windowsexperience/2018/12/06/microsoft-edge-making-the-web-better-through-more-open-source-collaboration/ ).

I don't know the exact versions for firefox/safari. I guess it is fine to put these values and fix them later if people report errors...

@ExE-Boss
Copy link
Contributor

Except that edge_mobile refers to Microsoft Edge on Windows 10 Mobile, which stopped being updated with EdgeHTML 15.

@Elchi3
Copy link
Member Author

Elchi3 commented Mar 25, 2019

Thanks @ExE-Boss and @fred-wang, let's merge this then.

@Elchi3 Elchi3 merged commit a37b44c into master Mar 25, 2019
@Elchi3 Elchi3 deleted the no-mathml-in-edge branch March 25, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants